Conversation
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 64.09% 64.05% -0.05%
==========================================
Files 40 40
Lines 2284 2323 +39
==========================================
+ Hits 1464 1488 +24
- Misses 698 709 +11
- Partials 122 126 +4 ☔ View full report in Codecov by Sentry. |
ghost
reviewed
Oct 30, 2023
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
ghost
reviewed
Nov 2, 2023
yizha1
reviewed
Nov 2, 2023
Contributor
yizha1
left a comment
There was a problem hiding this comment.
Thanks @FeynmanZhou . I did a first round review, will take another pass later.
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
shizhMSFT
reviewed
Nov 3, 2023
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Member
Author
|
@rgnote @priteshbandi @iamsamirzon Would you mind reviewing the notation plugin mgmt spec updates? Thanks |
ghost
reviewed
Nov 7, 2023
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
ghost
reviewed
Nov 20, 2023
ghost
reviewed
Nov 20, 2023
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
priteshbandi
pushed a commit
that referenced
this pull request
Dec 5, 2023
This PR is based on the spec PR: #809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
6 tasks
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
rgnote
pushed a commit
to rgnote/notation
that referenced
this pull request
Mar 8, 2024
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
FeynmanZhou
added a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
This PR is based on the spec PR: notaryproject#809. It adds the notation plugin uninstall command. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update notation plugin spec based on #549 and PRD
Added new commands and examples including:
Updated the output of
notation plugin list.