docs: spec updates for arbitrary blob signing by rgnote · Pull Request #811 · notaryproject/notation

rgnote · 2023-10-28T00:23:18Z

CLI Spec updated for Arbitrary blob signing. Proposal https://hackmd.io/ewbJr2ZnT4a8U1ObDVXcSw?view#CLI-Spec and https://hackmd.io/@-KPyDkW6QfGA-pldFa13pA/ByuHffALa

Signing Scheme and trust policy updates : notaryproject/specifications#283

Signed-off-by: rgnote 5878554+rgnote@users.noreply.github.com

codecov-commenter · 2023-10-28T00:25:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (eaa5fb4) to head (2750c4b).
Report is 9 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   64.93%   67.35%   +2.42%     
==========================================
  Files          45       45              
  Lines        2729     2166     -563     
==========================================
- Hits         1772     1459     -313     
+ Misses        795      545     -250     
  Partials      162      162

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

specs/commandline/blob.md

ghost · 2023-10-30T08:16:50Z

Before diving into the detailed UX design, shall we have a PR in the https://github.com/notaryproject/specifications repo to add the new specs related to blob? For example, signature payload, trust policy, ect.

specs/commandline/blob.md

specs/commandline/policy.md

specs/commandline/blob.md

yizha1

Thanks @rgnote I left some comments

specs/commandline/blob.md

yizha1

Thanks @rgnote. I left additional comments.

specs/commandline/blob.md

specs/commandline/policy.md

specs/commandline/blob.md

yizha1

LGTM with a nit, but I am not a maintainer of notation repo

specs/commandline/blob.md

specs/commandline/policy.md

specs/commandline/blob.md

priteshbandi

Should we add some note, for help of top level sign, verify, inspect and list that they only applies to oci.

rgnote · 2023-11-17T21:12:39Z

Should we add some note, for help of top level sign, verify, inspect and list that they only applies to oci.

They were already updated to note that they work with OCI artifacts.

priteshbandi

Approving this pull request, and we can address the following comments in the next PR:

Support 'blob sign' and 'verify' commands to function with standard input and output?
In my opinion, merely mentioning 'oci' in the command description (or in help) isn't sufficient; it should be more prominent

yizha1

LGTM with some minor comments.

specs/commandline/blob.md

specs/commandline/policy.md

specs/commandline/sign.md

specs/commandline/blob.md

specs/commandline/verify.md

specs/commandline/sign.md

specs/commandline/inspect.md

specs/commandline/blob.md

Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…project#872) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…roject#874) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…otaryproject#875) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…project#878) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…roject#879) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…roject#877) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…roject#883) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…roject#884) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…ect#886) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…project#887) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…roject#896) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…roject#895) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

… to 1.1.0 (notaryproject#891) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

Co-authored-by: Shiwei Zhang <shizh@microsoft.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…roject#898) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

…roject#901) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

CLI Spec updated for Arbitrary blob signing. Proposal https://hackmd.io/ewbJr2ZnT4a8U1ObDVXcSw?view#CLI-Spec and https://hackmd.io/@-KPyDkW6QfGA-pldFa13pA/ByuHffALa Signing Scheme and trust policy updates : notaryproject/specifications#283 Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com> --------- Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com> Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Cameron Rozean <rcrozean@gmail.com> Signed-off-by: Yi Zha <yizha1@microsoft.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com> Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: Toddy Mladenov <toddysm@gmail.com> Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Feynman Zhou <feynmanzhou@microsoft.com> Co-authored-by: Cameron Rozean <rcrozean@gmail.com> Co-authored-by: Yi Zha <yizha1@microsoft.com> Co-authored-by: Shiwei Zhang <shizh@microsoft.com> Co-authored-by: Milind Gokarn <milind81@gmail.com> Co-authored-by: Junjie Gao <junjiegao@microsoft.com> Co-authored-by: Toddy Mladenov <me@toddysm.com> Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>

rgnote requested review from JeyJeyGao, NiazFK, SteveLasker, gokarnm, justincormack, priteshbandi and shizhMSFT as code owners October 28, 2023 00:23

rgnote requested a review from a user October 28, 2023 00:23

shizhMSFT changed the title ~~Spec updates for arbitrary blob signing~~ doc: spec updates for arbitrary blob signing Oct 30, 2023

shizhMSFT changed the title ~~doc: spec updates for arbitrary blob signing~~ docs: spec updates for arbitrary blob signing Oct 30, 2023

JeyJeyGao reviewed Oct 30, 2023

View reviewed changes

specs/commandline/blob.md Outdated Show resolved Hide resolved

shizhMSFT reviewed Oct 30, 2023

View reviewed changes

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

ghost reviewed Oct 30, 2023

View reviewed changes

specs/commandline/policy.md Outdated Show resolved Hide resolved

ghost reviewed Nov 2, 2023

View reviewed changes

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

yizha1 reviewed Nov 2, 2023

View reviewed changes

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

yizha1 reviewed Nov 6, 2023

View reviewed changes

shizhMSFT reviewed Nov 6, 2023

View reviewed changes

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

ghost reviewed Nov 14, 2023

View reviewed changes

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

yizha1 reviewed Nov 15, 2023

View reviewed changes

specs/commandline/blob.md Outdated Show resolved Hide resolved

priteshbandi reviewed Nov 15, 2023

View reviewed changes

priteshbandi previously approved these changes Nov 18, 2023

View reviewed changes

yizha1 reviewed Nov 22, 2023

View reviewed changes

specs/commandline/blob.md Outdated Show resolved Hide resolved

specs/commandline/policy.md Outdated Show resolved Hide resolved

yizha1 reviewed Nov 22, 2023

View reviewed changes

specs/commandline/sign.md Outdated Show resolved Hide resolved

rgnote dismissed priteshbandi’s stale review via 5917140 November 24, 2023 19:36

ghost reviewed Nov 27, 2023

View reviewed changes

shizhMSFT reviewed Dec 7, 2023

View reviewed changes

specs/commandline/verify.md Outdated Show resolved Hide resolved

specs/commandline/sign.md Show resolved Hide resolved

specs/commandline/inspect.md Outdated Show resolved Hide resolved

specs/commandline/blob.md Outdated Show resolved Hide resolved

JeyJeyGao and others added 23 commits March 8, 2024 11:46

fix: improve error message for plugin (notaryproject#870)

17d7e1e

Signed-off-by: Junjie Gao <junjiegao@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump actions/upload-artifact from 4.1.0 to 4.2.0 (notary…

8e53eb0

…project#872) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump actions/cache from 3.3.3 to 4.0.0 (notaryproject#873)

b04cb09

Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump github/codeql-action from 3.23.0 to 3.23.1 (notaryp…

6d49323

…roject#874) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

bump: bump up notation-go and notation-core-go including e2e tests (n…

a538660

…otaryproject#875) Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

vote for version v1.1.0

4baf935

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump actions/upload-artifact from 4.2.0 to 4.3.0 (notary…

a442153

…project#878) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump codecov/codecov-action from 3.1.4 to 3.1.5 (notaryp…

ddf2c5e

…roject#879) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump github/codeql-action from 3.23.1 to 3.23.2 (notaryp…

f238f4f

…roject#877) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

bump: bump up oras-go and image-spec (notaryproject#881)

3a0562b

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump github/codeql-action from 3.23.2 to 3.24.0 (notaryp…

bbb4087

…roject#883) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump codecov/codecov-action from 3.1.5 to 4.0.1 (notaryp…

f8e613d

…roject#884) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump golang.org/x/term from 0.16.0 to 0.17.0 (notaryproj…

ecbea19

…ect#886) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump actions/upload-artifact from 4.3.0 to 4.3.1 (notary…

b1ab330

…project#887) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump codecov/codecov-action from 4.0.1 to 4.0.2 (notaryp…

194cab7

…roject#896) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump github/codeql-action from 3.24.0 to 3.24.5 (notaryp…

eae0fe3

…roject#895) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump github.com/opencontainers/image-spec from 1.1.0-rc6…

a22d8fd

… to 1.1.0 (notaryproject#891) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

remove overwrite option in sign command

8e0ce16

Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

Update specs/commandline/blob.md

1b9e88b

Co-authored-by: Shiwei Zhang <shizh@microsoft.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

Update specs/commandline/blob.md

a2ebf5c

Co-authored-by: Shiwei Zhang <shizh@microsoft.com> Signed-off-by: Rakesh Gariganti <5878554+rgnote@users.noreply.github.com> Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump codecov/codecov-action from 4.0.2 to 4.1.0 (notaryp…

7815b82

…roject#898) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump actions/cache from 4.0.0 to 4.0.1 (notaryproject#900)

58dd756

Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

build(deps): Bump actions/add-to-project from 0.5.0 to 0.6.0 (notaryp…

778245a

…roject#901) Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>

rgnote force-pushed the main branch from 52efd87 to 778245a Compare March 8, 2024 19:48

rgnote merged commit ba28208 into notaryproject:main Mar 8, 2024

This was referenced Jun 11, 2024

bump: bump up and vote notation v1.1.1 #963

Merged

bump: bump up and vote for v1.2.0-alpha.1 #967

Merged

priteshbandi mentioned this pull request Oct 15, 2024

Notation to sign and verify arbitrary data #741

Closed

Conversation

rgnote commented Oct 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

ghost commented Oct 30, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yizha1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yizha1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yizha1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

priteshbandi left a comment

Choose a reason for hiding this comment

Uh oh!

rgnote commented Nov 17, 2023

Uh oh!

priteshbandi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yizha1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

rgnote commented Oct 28, 2023 •

edited

Loading

codecov-commenter commented Oct 28, 2023 •

edited

Loading

priteshbandi left a comment •

edited

Loading