fix: improve error message for --signature-format flag#925
Merged
7 commits merged intonotaryproject:mainfrom Apr 18, 2024
Merged
fix: improve error message for --signature-format flag#9257 commits merged intonotaryproject:mainfrom
7 commits merged intonotaryproject:mainfrom
Conversation
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 64.93% 70.91% +5.98%
==========================================
Files 45 45
Lines 2729 2166 -563
==========================================
- Hits 1772 1536 -236
+ Misses 795 440 -355
- Partials 162 190 +28 ☔ View full report in Codecov by Sentry. |
ghost
reviewed
Apr 10, 2024
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
priteshbandi
approved these changes
Apr 17, 2024
This was referenced Jun 11, 2024
7h3-3mp7y-m4n
pushed a commit
to 7h3-3mp7y-m4n/notation
that referenced
this pull request
Mar 29, 2025
…#925) Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/notation
that referenced
this pull request
May 15, 2025
…#925) Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous error message:
Improved error message:
Test(not related to the fix):
Resolves #868
Signed-off-by: Junjie Gao junjiegao@microsoft.com