BUILD: use system python3 in the chroot#12299
Conversation
tools/travis-test.sh
Outdated
| libatlas-base-dev gfortran python-dev python-nose python-pip cython \ | ||
| python-pytest" | ||
| libatlas-base-dev gfortran python-dev python3-dev python-pip python3-pip \ | ||
| cython python3-pytest python-pytest" |
There was a problem hiding this comment.
Do we still need all the non-python3 versions if we are running Python3?
There was a problem hiding this comment.
possibly, but then we cannot run chroot python2 tests anymore. If that is the direction I will change this
tools/travis-test.sh
Outdated
| # run again in chroot with this time testing with python3 | ||
| sudo linux32 chroot $DIR bash -c \ | ||
| "cd numpy && PYTHON=python PIP=pip IN_CHROOT=1 $0 test" | ||
| "cd numpy && PYTHON=$PYTHON PIP=$PIP IN_CHROOT=1 $0 test" |
There was a problem hiding this comment.
Does PIP=$PIP make any sense here, it is already in the environment.
|
This seems over complicated for its stated purpose. |
|
There are four changes:
If we wish to only support python3 it can be simplified by removing 1, hardcoding python3 and pip3 into 2, and dropping the python2 packages from 3. I think 4 works outside the chroot because it is using a virtualenv, not clear to me if inside the chroot it is also in a virtualenv. |
|
I wonder if we can run 32 bit linux tests on azure-pipeline? We still have some slots before we hit the 10 parallel build limit. That doesn't help for releases yet, as they are still built on appveyor and travis, but it tmight be an easy way to get 32 testing on linux. As it is running in bionic, the default python3 is 3.6, which should be good for a while. Did you try just changing things to use |
Pretty sure |
|
Also, might be worth simplifying the i386 tests as suggested in the note EDIT: travis was to have switched to 14.04 as default in Aug, 2017. |
@charris Then we can only run chroot python3 tests. Is that OK, or do we wish to preserve the possibility of running python2 by changing |
There are two parts to the |
Do you mean my changes or the whole chroot 32 bit testing option in Travis itself suggests using docker, here is one example of a 32 bit docker command, it does not look less complicated than what we now have. I could try pursuing the |
We will be dropping Python2 support in a couple of weeks. |
|
changed to only use python3 in chroot |
|
Thanks Matti. |
|
The 32-bit 3.x Azure linux build seems prone to stalling during unit tests, so that's where I'm stuck at the moment on that. |
|
I wonder if i.e., 32-bit build / test on a 64-bit OS without linalg acceleration libraries is prone to issues -- I think that's my current config there. My first pass at getting the |
|
Interesting. Does it always stall at the same test? |
|
I think so, and same stall for 2.7 & 3.5. |
The chroot travis test used python2. Update it to use python3.