MAINT: Remove unused int_asbuffer#15229
Merged
mattip merged 1 commit intonumpy:masterfrom Jan 4, 2020
jdufresne:int_asbuffer
Merged
MAINT: Remove unused int_asbuffer#15229mattip merged 1 commit intonumpy:masterfrom jdufresne:int_asbuffer
mattip merged 1 commit intonumpy:masterfrom
jdufresne:int_asbuffer
Conversation
Member
|
Does anyone feel this should get a release note? I am tempted to simply put this this in as is (and may do so if no one disagrees in the next days). |
Member
|
Release notes are cheap :) |
On Python 3, int_asbuffer throws NotImplementedError and goes unused internally. Fixes #12425
Contributor
Author
|
I added some release notes. Let me know if this is what you had in mind. All feedback on wording and format welcome. |
Member
|
Thanks @jdufresne |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 3, int_asbuffer throws NotImplementedError and goes unused
internally.
Fixes #12425