MAINT: Eliminate some calls to eval#15249
Merged
mattip merged 2 commits intonumpy:masterfrom Jan 13, 2020
Merged
Conversation
Member
|
|
Member
Author
|
Have some local work to fix that based on #15254 |
46156a8 to
0f6bece
Compare
* The instance in `_internal` is parsing tuples and integers, so `ast.literal_eval` is just fine * The instance in `crack_fortran` is just trying to lookup a function name dynamically * The instance in `f90mod_rules` is looking at the result of `capi_maps.getarrdims(...)['rank']`, which is always a string representation of an integer The f2py code is still littered with `eval`, but the remaining cases were harder to reason about.
0f6bece to
c8bdb9c
Compare
Member
Author
eric-wieser
commented
Jan 12, 2020
Member
|
Thanks @eric-wieser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_internalis parsing tuples and integers, soast.literal_evalis just finecrack_fortranis just trying to lookup a function name dynamicallyf90mod_rulesis looking at the result ofcapi_maps.getarrdims(...)['rank'], which is always a string representation of an integerThe f2py code is still littered with
eval, but the remaining cases were harder to reason about.