Skip to content

BUG: fix the search dir of dispatch-able sources#16858

Merged
mattip merged 1 commit intonumpy:masterfrom
seiko2plus:ccopt_fix_inc_tmp_dir
Jul 14, 2020
Merged

BUG: fix the search dir of dispatch-able sources#16858
mattip merged 1 commit intonumpy:masterfrom
seiko2plus:ccopt_fix_inc_tmp_dir

Conversation

@seiko2plus
Copy link
Member

@seiko2plus seiko2plus commented Jul 14, 2020

Fix the search dir of dispatch-able sources to allow including the
generated config headers within the dispatch-able sources.

@seiko2plus seiko2plus mentioned this pull request Jul 14, 2020
Closed
@mattip
Copy link
Member

mattip commented Jul 14, 2020

I think the CircleCI failures would be fixed if this picked up gh-16857, since the Azure builds succeed. Could you just confirm that this changeset does not include gh-16857? No need to rebase, I am happy to merge without rebasing.

@seiko2plus
BUG: fix the search dir of dispatchable sources
7a4da65 
  to allow including the generated config headers within the dispatch-able sources.
@seiko2plus seiko2plus force-pushed the ccopt_fix_inc_tmp_dir branch from b71668a to 7a4da65 Compare July 14, 2020 11:58
@seiko2plus
Copy link
Member Author

seiko2plus commented Jul 14, 2020

@mattip, yes, gh-16857 wasn't included. I rebase it anyway.

@mattip
Copy link
Member

mattip commented Jul 14, 2020 •
edited
Loading

ahh, I was trying to conserve CI resources. oh well. CircleCI is happy now anyway

@mattip mattip merged commit c8d272d into numpy:master Jul 14, 2020
@mattip
Copy link
Member

mattip commented Jul 14, 2020

Thanks @seiko2plus

@seiko2plus seiko2plus mentioned this pull request Jul 16, 2020
Closed
@mattip mattip added the component: SIMD Issues in SIMD (fast instruction sets) code or machinery label Jul 21, 2020
@seiko2plus seiko2plus deleted the ccopt_fix_inc_tmp_dir branch January 9, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component: SIMD Issues in SIMD (fast instruction sets) code or machinery

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seiko2plus @mattip