Merged
Conversation
Make the instructions easy to see and hard to delete unread. Moves some text to new sections in dev/development_workflow.rst. The dashes above and below the heading, which in monospace seem too long, fit it well in Chromium browsers and reasonably in Firefox.
Colon missing in heading. Added sphinx anchor for PR-timeline (html anchor was OK).
Member
|
Let's give this a shot. Thanks @bjnath . |
Member
|
We may want to reduce the amount of whitespace by deleting blank lines. It probably won't help, but maybe some contributors will read the text if they don't have to scoll too far. |
Contributor
Author
|
@mattip I was thinking the exact same thing. |
bjnath
added a commit
to bjnath/numpy-1
that referenced
this pull request
Oct 8, 2020
Reduce the need to scroll, per @mattip suggestion in numpy#17440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the instructions easy to see and hard to delete unread.
Moves some text to new sections in dev/development_workflow.rst.
The dashes above and below the heading, which in monospace seem too long, fit it properly in Chromium browsers and reasonably in Firefox.