MAINT: py3k: remove os.fspath and os.PathLike backports #17473
MAINT: py3k: remove os.fspath and os.PathLike backports #17473eric-wieser merged 2 commits intonumpy:masterfrom zer0link:chain-exception
Conversation
|
Could you show an example of how this exception now looks? It should be easy to call this code with an object that trips it. |
|
This entire function is completely unreachable - we should just remove it. |
|
The error stack basically looks the same as before: |
Should I remove the function instead? |
|
The condition |
Updated based on comment |
|
Hi, I am having difficulties trying to run the failing tests locally, |
You may find this doc useful: https://numpy.org/doc/stable/dev/development_environment.html#running-tests |
|
The failures are unrelated, let's try rerunning |
|
Thanks @zer0link! |
| os_fspath = os.fspath | ||
| os_PathLike = os.PathLike |
There was a problem hiding this comment.
If you're looking to make another contribution, it would be great if we could find all the places that use np.compat.os_PathLike and replace them with os.PathLike.
|
Thanks @eric-wieser , was trying to debug the issue for some time now |
Related to #15986 .
Chain exceptions in "py3k.py" corresponding to exceptions on line 173 as mentioned in this comment.