Skip to content

ENH: type np.unicode_ as np.str_#17479

Merged
charris merged 2 commits intonumpy:masterfrom
person142:np-unicode
Oct 9, 2020
Merged

ENH: type np.unicode_ as np.str_#17479
charris merged 2 commits intonumpy:masterfrom
person142:np-unicode

Conversation

@person142
Copy link
Member

The two are aliases; i.e.

>>> np.unicode_ is np.str_
True

so make them aliases on the typing level too.

The two are aliases; i.e.

>>> np.unicode_ is np.str_
True

so make them aliases on the typing level too.
Copy link
Member

@BvB93 BvB93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; CI failure is unrelated (see #17499).

@charris charris closed this Oct 8, 2020
@charris charris reopened this Oct 8, 2020
@charris charris merged commit dee7399 into numpy:master Oct 9, 2020
@charris
Copy link
Member

charris commented Oct 9, 2020

Thanks @person142 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants