Skip to content

DOC: Fix the references for random.*#17483

Merged
rossbar merged 5 commits intonumpy:masterfrom
takanori-pskq:i13114-randomstate-in-release-notes
Oct 8, 2020
Merged

DOC: Fix the references for random.*#17483
rossbar merged 5 commits intonumpy:masterfrom
takanori-pskq:i13114-randomstate-in-release-notes

Conversation

@takanori-pskq
Copy link

Related to #13114.

@mattip
Copy link
Member

mattip commented Oct 7, 2020

I think this didn't work

@takanori-pskq
Copy link
Author

Fixed.
(At 90bbb1a, as you pointed the links are still broken, but sphinx emits no warnings...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would changing this to .. currentmodule:: numpy.random have been enough to fix the links?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to be enough.

@rossbar rossbar force-pushed the i13114-randomstate-in-release-notes branch from 1cca516 to fd87736 Compare October 8, 2020 15:16
@rossbar
Copy link
Contributor

rossbar commented Oct 8, 2020

Rebase + push to retrigger CI

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @eric-wieser 's suggestion did the trick! Will merge as soon as CI completes.

@rossbar rossbar merged commit 7396e03 into numpy:master Oct 8, 2020
@takanori-pskq takanori-pskq deleted the i13114-randomstate-in-release-notes branch October 9, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants