Merged
Conversation
Also clarify a wording.
One paragraph on `__common_dtype` in the alternatives was already before very confusing. This makes it hopefully more clear.
Member
|
Thanks, I pushed a small fixup directly, since in-line "suggestions" wouldn't work for most of them. |
Member
|
Thanks a lot Ben! I asked Ross to also take a quick look, and made the (somewhat last minute) decision to change the title. This doesn't need to be the last change, so going to put it in, but I would like a larger audience to review the decisions and hopefully get a decision out of the way to make sure everyone is on the same page that we do this without major changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revisions with @seberg of some additional sections.