DOC: Update top links in landing page#17523
Merged
charris merged 3 commits intonumpy:masterfrom Oct 13, 2020
Merged
Conversation
Same intent as PR numpy#17365 -- point "Installation" links to Hugo, start page with "What is NumPy", let Hugo page link to "Troubleshooting ImportError".
To fix CircleCI fail; missed it in the c6dc9d6 commit.
eric-wieser
reviewed
Oct 10, 2020
Member
|
This looks good to me, thanks @bjnath . The only detail that bugs me is that the installation link in the main menu does not have a subheader and looks different from all the others. But I don't think there's anything we could write there that would be clearer than the title. |
melissawm
approved these changes
Oct 13, 2020
Member
|
Thanks Ben. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same intent as PR #17365 -- point "Installation" links to Hugo, start
page with "What is NumPy", let Hugo page link to "Troubleshooting ImportError".