CI: Make merge ref grabbing conditional on the PR being active#17525
Merged
charris merged 3 commits intonumpy:masterfrom Oct 9, 2020
Merged
CI: Make merge ref grabbing conditional on the PR being active#17525charris merged 3 commits intonumpy:masterfrom
charris merged 3 commits intonumpy:masterfrom
Conversation
Only attempt to pull from refs/pull/xxxx/merge when pr is still active.
Member
|
Yes, that seems like the correct hypothesis |
Member
|
CircleCI works again, that is enough to merge this. |
Member
|
Thanks Ross. |
Member
|
This seems to have broken testing for merges to the master branch. |
Contributor
Author
|
I should've had this marked as WIP - I was hoping to test it on my own fork last evening but circleci itself was acting up and I never had a chance to. So it looks like this didn't fix the original problem. I'm traveling today but should be able to look at it again tomorrow. In the mean time, devdoc deployment could be fixed by either 1) commenting out this |
Member
|
No rush. It only bothers me because I get notifications on merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix #17524 . Only attempt to pull from
refs/pull/XXXXX/mergewhile the PR is still active. This fix is based on the hypothesis thatCI_PULL_REQUESTis not set after a PR has been merged.@mattip does this seem like it's on the right track?