Skip to content

TST: use a more standard workflow for PyPy#17695

Merged
charris merged 2 commits intonumpy:masterfrom
mattip:pypy
Nov 2, 2020
Merged

TST: use a more standard workflow for PyPy#17695
charris merged 2 commits intonumpy:masterfrom
mattip:pypy

Conversation

@mattip
Copy link
Member

@mattip mattip commented Nov 2, 2020

Now that PyPy is available on azure pipelines, there is no reason to download it specially.

  • Update the (now unused) build script, just in case we decided to go that route
  • Update the PyPy job and break it into steps
  • check the OpenBLAS version before running tests, just in case the tests segfault, so it is clear which OpenBLAS is being used

@mattip
Copy link
Member Author

mattip commented Nov 2, 2020

This also provides a basis for moving more ubuntu tests to azure if travis.com does not pan out

@mattip mattip force-pushed the pypy branch 3 times, most recently from 364f374 to f3d5ab6 Compare November 2, 2020 13:13
@mattip
Copy link
Member Author

mattip commented Nov 2, 2020

The azure jobs pass - ready for review.

@charris
Copy link
Member

charris commented Nov 2, 2020

Is pypy-test.sh even used anymore?

@mattip
Copy link
Member Author

mattip commented Nov 2, 2020

No. Should I delete it? There are other files in that directory that also are not used.

@charris
Copy link
Member

charris commented Nov 2, 2020

No. Should I delete it?

I was just wondering why you modified it. If you think it may be used again later I'd say keep it, if not, might as well delete it.

@mattip
Copy link
Member Author

mattip commented Nov 2, 2020

Not sure at this point. CI is in such a state of flux, I would like to keep it around for a while.

@charris charris merged commit 1a12887 into numpy:master Nov 2, 2020
@charris
Copy link
Member

charris commented Nov 2, 2020

Thanks Matti.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants