Skip to content

MAINT: Rename DtypeLike to DTypeLike#17699

Merged
seberg merged 1 commit intonumpy:masterfrom
BvB93:DTypeLike
Nov 3, 2020
Merged

MAINT: Rename DtypeLike to DTypeLike#17699
seberg merged 1 commit intonumpy:masterfrom
BvB93:DTypeLike

Conversation

@BvB93
Copy link
Member

@BvB93 BvB93 commented Nov 3, 2020

Closes #16562.

Changes to name of the (public) DtypeLike type-alias to DTypeLike,
thus making its name consist with the dtype-naming scheme used in nep 40, 41 & 42.

Note that this change will be backwards compatible, DtypeLike/DTypeLike being an object newly introduced in NumPy 1.20.

@BvB93 BvB93 added 03 - Maintenance 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. 41 - Static typing labels Nov 3, 2020
@BvB93 BvB93 added this to the 1.20.0 release milestone Nov 3, 2020
from typing import Any

import numpy as np
from numpy.typing import DtypeLike, _SupportsArray
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import.

@seberg
Copy link
Member

seberg commented Nov 3, 2020

Thanks Bas, if anyone has concerns about this rename we can reconsider, but it sounds like there is consensus.

@seberg seberg merged commit 4c83c04 into numpy:master Nov 3, 2020
@BvB93 BvB93 deleted the DTypeLike branch November 3, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

03 - Maintenance 41 - Static typing 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DISCUSS: Consider whether it should be Dtypelike or DTypeLike

2 participants