DOC: add docstring for TooHardError#18013
Conversation
|
What we are looking for is a docstring for the class, like the one for |
|
@Radhika14soni are you planning to update this PR with the change requested by @mattip? |
|
Yes
…On Sun, Jan 24, 2021, 15:52 Ralf Gommers ***@***.***> wrote:
@Radhika14soni <https://github.com/Radhika14soni> are you planning to
update this PR with the change requested by @mattip
<https://github.com/mattip>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18013 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANFCBTW2ZONGAK7J7NBAOXLS3PYGTANCNFSM4U7RR7QQ>
.
|
|
Gentle ping, @Radhika14soni . Do you need help with moving this forward? |
|
Hello there, @melissawm and @Radhika14soni, nice to meet you! I would like to help with moving this PR forward. |
|
Hello there, @Radhika14soni. I believe it is important to emphasize that I am also a complete new contributor to numpy community and hopefully will have the chance to grow together with you and all the amazing team. Let's start, I followed a discussion on Dec 17, 2020, where there was a proposal to get the issue done by analyzing the docstrings as implemented for the other exceptions classes at the same file. You have proposed the following change For the original code Taking a look at others Hope to hear from you soon, |
|
We are looking for the class |
|
@mattip and @InessaPawson First, my apologies for the slow reply. Now, a few questions.
Finally, I am writing something more like this, still working on the information on how to mitigate it: Do you think it's all right to do it? Best Regards, |
|
(1) and (2): I think you can restart this on your own fork, with any branch name you choose. (3) This exception does not really need all those sections. Let's start with just the docstring and see where we go from there. The string you have looks like a good start. |
|
The task has been completed in #21471. We can close this pull request. |
xref gh-10106
Added DocString function in TooHardError. Please let me know if changes are required. Since it's my first contribution.