ENH: Improve the annotations of np.core._internal#19029
Merged
charris merged 4 commits intonumpy:mainfrom May 20, 2021
Merged
Conversation
eric-wieser
reviewed
May 18, 2021
eric-wieser
reviewed
May 18, 2021
Member
Author
|
The tests are acting up for some reason; closing and re-opening. |
This was referenced May 18, 2021
Member
Author
|
Restarting tests again. |
Co-Authored-By: Eric Wieser <425260+eric-wieser@users.noreply.github.com>
Member
|
Thanks Bas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the annotations of the
_ctypesclass innp.core._internal,instances of which are exposed via the
ndarray.ctypesattribute.When the module was originally annotated way back when the builtin
ctypesmodule was insufficiently stubbed out to properly annotate aforementioned class. These days, this is not so much of an issue, hence allowing for the improvements introduced in this PR.