Skip to content

DOC: adding docstring to TooHardError class#21471

Merged
melissawm merged 5 commits intonumpy:mainfrom
angellicadearaujo:main
Jun 1, 2022
Merged

DOC: adding docstring to TooHardError class#21471
melissawm merged 5 commits intonumpy:mainfrom
angellicadearaujo:main

Conversation

@angellicadearaujo
Copy link
Contributor

issue: 10106

Changes were made according to the previous request for a docstring to the class TooHardError.

Please let me know if any further changes are required,
Thanks for your attention

@charris
Copy link
Member

charris commented May 10, 2022

This looks generally good to me. @melissawm Want to take a look.

@angellicacardozo You are almost set up right, but not quite. We can work with this, but in the future you will want to make a new branch. If you currently have main checked out, make a new branch like so

$ git branch document-tooharderror
$ git checkout document-tooharderror
...
work, work work, commit
...

If you are working in your local branch, you then push to your own github repo

$ git push origin HEAD  # skip if working on github

Then make a pull request for that branch.

You will also want to start with a clean repository next time. You can either redo the clone and all that bit, which is the easiest if you are not experienced, or you can try removing this commit and cleaning up from there. We can walk you through the process if you choose the latter.

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few optional comments, overall looks ok - @angellicacardozo let us know if you need help with setting up your branch :)

angellicadearaujo and others added 3 commits May 26, 2022 19:57
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
@angellicadearaujo
Copy link
Contributor Author

@melissawm @InessaPawson, suggestions were applied in the latest commit. I hope you appreciate it. Also, conversations are automatically resolved by GitHub when using suggested changes. Should I keep it open and wait for you to mark it as resolved? Please let me know what your thoughts are. Regards

@melissawm
Copy link
Member

Looking to to me - thanks @angellicacardozo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants