API: Remove interrupt handling and noprefix.h#23919
Merged
mattip merged 4 commits intonumpy:mainfrom Jun 12, 2023
Merged
Conversation
Member
Author
|
Major downstream packages don't use |
6214744 to
c2f963c
Compare
c2f963c to
2560870
Compare
mattip
approved these changes
Jun 12, 2023
| directory = "c_api_removal" | ||
| name = "NumPy 2.0 C API removals" | ||
| showcontent = true | ||
|
|
Member
There was a problem hiding this comment.
Do you want to add snippets for the removals in #23916?
Member
Author
There was a problem hiding this comment.
I wasn't going to, because those have all been effectively removed already (use is always an error)
Member
|
Thanks @seberg |
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Mar 13, 2024
The `npy_interrupt.h` header that needed it was removed in numpygh-23919 for 2.0.0.
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Mar 15, 2024
The `npy_interrupt.h` header that needed it was removed in numpygh-23919 for 2.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have removed the interrupt handling from the docs a long time ago with a big comment to try to discourage them, so I don't think this should be controversial.
The
noprefix.his also so old, that I suspect we can get away with asking users to fix their code, but if anyone thinks otherwise (or maybe rather complains strongly after the fact), I am OK with reconsidering.Adds a category in the release notes for the removals, since I think the list will get long (likely we should format it as a table at some point, but for now I think I prefer not to have two processes in parallel).
This is a draft because it is based on top of gh-23916