ENH: Improve clang-cl compliance#24162
Conversation
Avoid unnecessary MSVC path when using clang-cl
|
There are 4 test failures |
|
Thanks for reviving clang-cl compliance. The einsum tests seem sensitive to SIMD semantics, and were xfailed on macos with the move to meson. I don't remember seeing the |
fe5fdcf to
124e8fc
Compare
|
Any idea why |
|
The |
rgommers
left a comment
There was a problem hiding this comment.
This all LGTM now, thanks @bashtage.
For the new CI job, onfigure output is clean:
C compiler for the host machine: clang-cl (clang-cl 16.0.6)
C linker for the host machine: lld-link lld-link 16.0.6
C++ compiler for the host machine: clang-cl (clang-cl 16.0.6)
C++ linker for the host machine: lld-link lld-link 16.0.6
The build log is pretty messy, but that's mostly a lot of repeats of:
In file included from C:\hostedtoolcache\windows\Python\3.11.4\x64\Include\Python.h:86:
C:\hostedtoolcache\windows\Python\3.11.4\x64\Include/cpython/pytime.h(184,12): warning: declaration of 'struct timeval' will not be visible outside of this function [-Wvisibility]
struct timeval *tv,
^
C:\hostedtoolcache\windows\Python\3.11.4\x64\Include/cpython/pytime.h(190,12): warning: declaration of 'struct timeval' will not be visible outside of this function [-Wvisibility]
plus some lapack_lite operator precedence warnings. Nothing that requires addressing now or is specific to clang-cl.
This is a follow up of numpy#26602 and numpy#24162 where previously the test fails on Clang-cl. I've tried a few CI runs on my fork and it seems the test passes now.
Avoid unnecessary MSVC path when using clang-cl
This patch lets NumPy 2.0.0-dev compile using clang-cl on Windows.