Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
r-devulap
reviewed
Jul 18, 2023
Member
|
|
Member
|
Thanks Nathan. |
This was referenced Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23116
Adds a github actions job that runs the tests under both address sanitizer and undefined behavior sanitizer.
There are some undefined behavior errors when I run the tests locally so this will not fail the build if an error happens until those are fixed. I will be filing a separate issue about the undefined behavior reports.