BUG: Fix reference count leak in str(scalar).#24211
Merged
ngoldbaum merged 1 commit intonumpy:mainfrom Jul 18, 2023
Merged
Conversation
PyArray_DescrFromTypeObject() returns a fresh reference to the descriptor object, which must be freed. This leak was introduced in numpy@670842b
Member
charris
added a commit
to charris/numpy
that referenced
this pull request
Jul 26, 2023
In numpygh-22449 `descr` was renamed `dtype`, which broke the build as numpygh-24211 decrefed the old variable to fix a reference leak. This bug slipped in because numpygh-22449 was not retested after the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyArray_DescrFromTypeObject() returns a fresh reference to the descriptor object, which must be freed.
This leak was introduced in
670842b
The leak was released in NumPy 1.25, so this change may be a 1.25 backport candidate.
Bug found while running the Google Protobuf test suite under NumPy 1.25, which stringifies NumPy arrays in some of its tests, and has a test harness for detecting reference count leaks: https://github.com/protocolbuffers/protobuf/blob/49d3bca39f96f7709d48aaea4f5d30c11a943690/python/google/protobuf/internal/testing_refleaks.py