BLD/CI: re-enable ILP64 usage and PyPy job in Azure#24238
Merged
mattip merged 3 commits intonumpy:mainfrom Jul 24, 2023
Merged
Conversation
Also improve the `show_config` output (fixes one of the issues discussed in numpygh-24200), and improve handling of BLAS related logic in `numpy/meson.build`. The `OPENBLAS64_` environment variable is only used in `numpy.distutils.system_info`, so remove it from the places where we no longer use `numpy.distutils`.
Member
Author
|
Not a bad start, the only failure is the re-enabled PyPy job, with: EDIT: the numpy build seems to be fine, result is |
4aa5c85 to
9654944
Compare
This was broken with `undefined symbol: dlapy3_` because the test suite imports `linalg.lapack_lite` directly. See numpygh-24200 for more details.
`threadpoolctl.threadpool_info()` returns an empty list for some reason, even though all tests on PyPy pass. This works locally just fine too with PyPy 7.3.11
9654944 to
f10e6b7
Compare
Member
Author
|
This should be good to go now. @charris I think the |
mattip
approved these changes
Jul 24, 2023
Member
mattip
left a comment
There was a problem hiding this comment.
Just one small niggle, overall a nice cleanup. It is fine to merge as-is.
| if len(data) != 1: | ||
| if platform.python_implementation() == 'PyPy': | ||
| print(f"Check broken in CI on PyPy, data is: {data}") | ||
| return |
Member
There was a problem hiding this comment.
Maybe not worth the effort to explore, but this is strange.
Member
Author
There was a problem hiding this comment.
It failed in CI, then I did go through the effort of setting up a PyPy dev env locally, but there it worked fine. So I'd like to punt on this at least for now.
Member
|
Thanks @rgommers |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improve the
show_configoutput (fixes one of the issues discussed in gh-24200), and improve handling of BLAS related logic innumpy/meson.build.The
OPENBLAS64_environment variable is only used innumpy.distutils.system_info, so remove it from the places where we no longer usenumpy.distutils.