Merged
Conversation
Contributor
Author
seberg
reviewed
Jul 24, 2023
Member
There was a problem hiding this comment.
These and above are also wrong (or maybe just badly named). Probably makes sense to just use npy_<name>, although they are the same anyway.
(I suppose, in practice we probably don't support any platform for which all but long aren't correct.)
numpy#23746 introduced a fast path for scalar int conversions, but the map between Python types and C types was subtly wrong. This fixes tests on at least ppc32 (big-endian). Many thanks to Sebastian Berg for debugging this with me and pointing out what needed to be fixed. Closes numpy#24239. Fixes: 81caed6
f5eb12c to
d9c0c96
Compare
seberg
approved these changes
Jul 25, 2023
Member
seberg
left a comment
There was a problem hiding this comment.
Force pushed the larger fix, good to go now.
Contributor
Author
Thanks! Sorry I hadn't got back to it yet, appreciate you finishing it off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#23746 introduced a fast path for scalar int conversions, but the map between Python types and C types was subtly wrong.
This fixes tests on at least ppc32 (big-endian).
Many thanks to Sebastian Berg for debugging this with me and pointing out what needed to be fixed.
Closes #24239.
Fixes: 81caed6