TYP: Trim down the _NestedSequence.__getitem__ signature#24273
Merged
seberg merged 1 commit intonumpy:mainfrom Jul 31, 2023
Merged
TYP: Trim down the _NestedSequence.__getitem__ signature#24273seberg merged 1 commit intonumpy:mainfrom
_NestedSequence.__getitem__ signature#24273seberg merged 1 commit intonumpy:mainfrom
Conversation
Remove the `slice`-based overload such that it successfully supertypes `deque.__getitem__`
Member
|
Looks right to me, thanks. Sequences don't need to support slicing. |
_NestedSequence.__getitem__ signature_NestedSequence.__getitem__ signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24265
Remove the
slice-based overload so that it successfully supertypesdeque.__getitem__, the latter lacking support for it despite subtyping theSequenceabstract base class.