BUG: cleanup warnings [skip azp][skip circle][skip travis][skip cirrus]#24413
Merged
charris merged 1 commit intonumpy:mainfrom Aug 14, 2023
Merged
BUG: cleanup warnings [skip azp][skip circle][skip travis][skip cirrus]#24413charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
charris
approved these changes
Aug 14, 2023
Member
|
Thanks Matti. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
sys.flags.optimizeinstead ofPy_OptimizeFlagwhich was deprecated in 3.12. See the discussion in Allow efficient read access to PyConfig options python/cpython#99872. Cython also came across this deprecation, and chose a different solution to avoid holding the GIL but uses private interfaces.