CI: GitHub Actions CI job restructuring#24493
Merged
charris merged 4 commits intonumpy:mainfrom Aug 22, 2023
Merged
Conversation
28d2aab to
775cb6e
Compare
Also documents better what is being run. See numpygh-24410 for the overall restructuring plan for GitHub Actions CI.
[skip azp] [skip cirrus] [skip circle] [skip travis]
Member
Author
|
This is happy now. Should make it easier to iterate on things in parallel after this is merged. We basically have to get rid of |
charris
reviewed
Aug 22, 2023
| - uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1 # v4.7.0 | ||
| with: | ||
| python-version: '3.11' | ||
|
|
Member
There was a problem hiding this comment.
Could get rid of the blank line at some point.
Member
|
Thanks Ralf. |
Member
|
Here are the current workflows on github actions and the time they take to run (after merging this PR)
In addition we have the
|
Member
Author
|
Thanks! That's a useful overview. Perhaps good to post it on gh-24410 too (more discoverable)? I think we should first get rid of all the |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Nov 5, 2023
This is a backport of numpy#24493 and numpy#24291. The purpose of this is to ease future backports that expect these files. - CI: move some jobs in `build_test.yml` to Meson - CI: split `build_test.yml` into three GHA jobs files Also documents better what is being run. See numpygh-24410 for the overall restructuring plan for GitHub Actions CI. - CI: merge `linux_meson.yml` into `linux_blas.yml` - TST: disable mypy tests in test suite unless an environment variable is set These tests are super slow, and they're effectively always passing in CI. Running them on all "full" test suite runs is too expensive. Note that SciPy has an XSLOW mark, NumPy does not. So use an env var for now. - CI: add new GHA CI jobs to run MyPy across OS/Python flavors
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Nov 11, 2023
This is a backport of numpy#24493 and numpy#24291. The purpose of this is to ease future backports that expect these files. - CI: move some jobs in `build_test.yml` to Meson - CI: split `build_test.yml` into three GHA jobs files Also documents better what is being run. See numpygh-24410 for the overall restructuring plan for GitHub Actions CI. - CI: merge `linux_meson.yml` into `linux_blas.yml` - TST: disable mypy tests in test suite unless an environment variable is set These tests are super slow, and they're effectively always passing in CI. Running them on all "full" test suite runs is too expensive. Note that SciPy has an XSLOW mark, NumPy does not. So use an env var for now. - CI: add new GHA CI jobs to run MyPy across OS/Python flavors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements most of what is discussed in gh-24410, and documents what each job does. It removes some duplicate jobs, and adds a few notes and TODOs for where we miss coverage.
For the two files with a large number of jobs (
linux.ymlandlinux_simd.yml) we run the samesmoke_testwhich acts as a gate for the other jobs. That's an unavoidable duplication, but it takes only ~6 minutes so that should be fine. If there are only 2-3 jobs in a yml file, we don't run a smoke test. Overall, this will cut down on the number of jobs and make them easier to maintain.