BUG: fix comparisons between masked and unmasked structured arrays#24556
Merged
mattip merged 2 commits intonumpy:mainfrom Aug 27, 2023
Merged
BUG: fix comparisons between masked and unmasked structured arrays#24556mattip merged 2 commits intonumpy:mainfrom
mattip merged 2 commits intonumpy:mainfrom
Conversation
Member
|
CircleCI was actually failing here. Would you mind fixing in a follow-up PR @mhvk? |
Contributor
Author
|
Oops, sorry! Testing is slow enough that I fear I only ran the regular tests, not doctests, and I hadn't had a chance to look at CI before this was merged. Anyway, fix (and added test) in #24559 |
Contributor
Author
|
OK, doctests should be fixed in main again... |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24554, where it was noted that currently comparing a masked structured array with an unmasked one fails:
While looking at the code, it seemed obvious that a correction to the mask shape done inside an
ifstatement should really be outside. A quick test confirmed that. So, the second commit fixes that too. I can make it 2 PRs if need be (but am trying to just be done...)Not sure about the milestone. I put 1.26.0, but that may be too late. This definitely is not very urgent, since the bug has been there for years.