BLD: meson-cpu: fix SIMD support on platforms with no features#24601
Merged
charris merged 1 commit intonumpy:mainfrom Aug 31, 2023
Merged
BLD: meson-cpu: fix SIMD support on platforms with no features#24601charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
This code returned an empty list rather than an empty dict on platforms that don't have a key in `max_features_dict`. That would break the build on the next `foreach` statement, which needs a dict. [skip cirrus] [skip circle] [skip azp]
charris
approved these changes
Aug 31, 2023
Member
|
Thanks Ralf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code returned an empty list rather than an empty dict on platforms that don't have a key in
max_features_dict. That would break the build on the nextforeachstatement, which needs a dict.