Skip to content

Comments

API: Add svdvals to numpy.linalg [Array API]#24940

Merged
ngoldbaum merged 1 commit intonumpy:mainfrom
mtsokol:array-api-svdvals
Dec 5, 2023
Merged

API: Add svdvals to numpy.linalg [Array API]#24940
ngoldbaum merged 1 commit intonumpy:mainfrom
mtsokol:array-api-svdvals

Conversation

@mtsokol
Copy link
Member

@mtsokol mtsokol commented Oct 17, 2023

This PR contains next Array API compatibility change. It adds numpy.linalg.svdvals (similar to scipy.linalg.svdvals) with docs taken from Array API specification.

@mtsokol mtsokol self-assigned this Oct 17, 2023
@mtsokol mtsokol force-pushed the array-api-svdvals branch 3 times, most recently from 3ea2567 to 71fe26a Compare October 23, 2023 10:03
@mtsokol mtsokol force-pushed the array-api-svdvals branch 2 times, most recently from 28491ac to cb1e230 Compare October 25, 2023 08:42
@mtsokol mtsokol force-pushed the array-api-svdvals branch 2 times, most recently from 8d1d5f5 to 9bccf09 Compare October 26, 2023 16:38
Copy link
Member

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll wait for @charris or someone else to look this over before merging since this is new API.

@rgommers rgommers added this to the 2.0.0 release milestone Oct 27, 2023
@mtsokol mtsokol force-pushed the array-api-svdvals branch 2 times, most recently from 94088ee to 9942713 Compare November 29, 2023 11:24
@ngoldbaum
Copy link
Member

This has a conflict that needs to be fixed

@ngoldbaum
Copy link
Member

In it goes, thanks @mtsokol!

@ngoldbaum ngoldbaum merged commit 544e54f into numpy:main Dec 5, 2023
@mtsokol mtsokol deleted the array-api-svdvals branch April 3, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants