MAINT: Remove unhelpful error replacements from import_array()#24958
Merged
ngoldbaum merged 1 commit intonumpy:mainfrom Oct 20, 2023
Merged
MAINT: Remove unhelpful error replacements from import_array()#24958ngoldbaum merged 1 commit intonumpy:mainfrom
import_array()#24958ngoldbaum merged 1 commit intonumpy:mainfrom
Conversation
Replacing the original error is just not useful and actively unhelpful since the original array may have more information. We could chain the error, but there seems little reason to do so.
Member
|
Agreed, this was extremely confusing to debug the other day. |
import_array()import_array()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the original error is just not useful and actively unhelpful since the original array may have more information.
We could chain the error, but there seems little reason to do so.
Should backport this, although we would need to backport it very far back to be very helpful in practice.