BLD: clean up incorrect-but-hardcoded define for strtold_l check.#24979
Merged
charris merged 1 commit intonumpy:mainfrom Oct 24, 2023
Merged
BLD: clean up incorrect-but-hardcoded define for strtold_l check.#24979charris merged 1 commit intonumpy:mainfrom
strtold_l check.#24979charris merged 1 commit intonumpy:mainfrom
Conversation
GNU-specific and missing on many platforms, see https://www.gnu.org/software///gnulib/manual/html_node/strtold_005fl.html If it does go missing, the only problem seems to be some minor changes in long double printing code, failing two tests: ``` ______________________________ test_str_roundtrip ______________________________ @pytest.mark.skipif(IS_MUSL, reason="test flaky on musllinux") @pytest.mark.skipif(LD_INFO.precision + 2 >= repr_precision, reason="repr precision not enough to show eps") def test_str_roundtrip(): # We will only see eps in repr if within printing precision. o = 1 + LD_INFO.eps > assert_equal(np.longdouble(str(o)), o, "str was %s" % str(o)) E AssertionError: E Items are not equal: str was 1.0000000000000000001 E ACTUAL: np.longdouble('1.0') E DESIRED: np.longdouble('1.0000000000000000001') o = np.longdouble('1.0000000000000000001') numpy/_core/tests/test_longdouble.py:43: AssertionError ____________________ TestRealScalars.test_dragon4_interface ____________________ self = <numpy._core.tests.test_scalarprint.TestRealScalars object at 0x7f5804791df0> def test_dragon4_interface(self): tps = [np.float16, np.float32, np.float64] # test is flaky for musllinux on np.float128 if hasattr(np, 'float128') and not IS_MUSL: tps.append(np.float128) fpos = np.format_float_positional fsci = np.format_float_scientific for tp in tps: # test padding assert_equal(fpos(tp('1.0'), pad_left=4, pad_right=4), " 1. ") assert_equal(fpos(tp('-1.0'), pad_left=4, pad_right=4), " -1. ") > assert_equal(fpos(tp('-10.2'), pad_left=4, pad_right=4), " -10.2 ") E AssertionError: E Items are not equal: E ACTUAL: ' -10.1999999999999992895' E DESIRED: ' -10.2 ' fpos = <function format_float_positional at 0x7f580b047700> fsci = <function format_float_scientific at 0x7f580b047670> self = <numpy._core.tests.test_scalarprint.TestRealScalars object at 0x7f5804791df0> tp = <class 'numpy.longdouble'> tps = [<class 'numpy.float16'>, <class 'numpy.float32'>, <class 'numpy.float64'>, <class 'numpy.longdouble'>] numpy/_core/tests/test_scalarprint.py:276: AssertionError =========================== short test summary info ============================ FAILED numpy/_core/tests/test_longdouble.py::test_str_roundtrip - AssertionError: Items are not equal: str was 1.0000000000000000001 ACTUAL: np.longdouble('1.0') DESIRED: np.longdouble('1.0000000000000000001') FAILED numpy/_core/tests/test_scalarprint.py::TestRealScalars::test_dragon4_interface - AssertionError: Items are not equal: ACTUAL: ' -10.1999999999999992895' DESIRED: ' -10.2 ' ``` put GNU-source above locale.h fix issue in numpyos.c
c021262 to
9f1dd22
Compare
Member
|
Let's give it a shot. Thanks Ralf. |
charris
added a commit
that referenced
this pull request
Nov 6, 2023
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 11, 2023
Backports of numpy#24969, numpy#24979, numpy#24968, numpy#25068. * apply 24969.diff * apply 24979.diff * apply 24968.diff * TST: skip flaky test in test_histogram --------- Co-authored-by: mattip <matti.picus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to gh-24968, which touched this check because it was incorrect for MinGW-w64.
strtold_lis GNU-specific and missing on many platforms, see https://www.gnu.org/software///gnulib/manual/html_node/strtold_005fl.html.If it does go missing, the only problem seems to be some minor changes in long double printing code, failing two tests: