Skip to content

BUG: Disallow shadowed modulenames#25114

Closed
HaoZeke wants to merge 2 commits intonumpy:mainfrom
HaoZeke:gh-22819
Closed

BUG: Disallow shadowed modulenames#25114
HaoZeke wants to merge 2 commits intonumpy:mainfrom
HaoZeke:gh-22819

Conversation

@HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Nov 11, 2023

Closes #22819.

Enforces the following:

  • Warns (but doesn't break, for BC) when -m is passed with a .pyf in a -c call, the name is ignored and taken from the .pyf file (the only logical option)
  • Each -c run will only produce one python module, so there can only be one .pyf file

There already is a note in the documentation, but this is a much better solution (and also paves the way for #25111).

@mattip
Copy link
Member

mattip commented Nov 13, 2023

Could this be tested?

@HaoZeke
Copy link
Member Author

HaoZeke commented Nov 19, 2023

Closing in favor of #25181

@HaoZeke HaoZeke closed this Nov 19, 2023
@HaoZeke HaoZeke deleted the gh-22819 branch November 19, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: Clarify the interaction between -m MODULENAME and .pyf files

2 participants