Skip to content

Comments

API: Add cross to numpy.linalg [Array API]#25145

Merged
ngoldbaum merged 1 commit intonumpy:mainfrom
mtsokol:array-api-cross
Dec 5, 2023
Merged

API: Add cross to numpy.linalg [Array API]#25145
ngoldbaum merged 1 commit intonumpy:mainfrom
mtsokol:array-api-cross

Conversation

@mtsokol
Copy link
Member

@mtsokol mtsokol commented Nov 14, 2023

This PR contains next Array API compatibility change. It adds numpy.linalg.cross (almost the same as numpy.cross) with docs taken from Array API specification.

@mtsokol mtsokol self-assigned this Nov 14, 2023
@mtsokol mtsokol mentioned this pull request Nov 14, 2023
Closed
23 tasks
@mtsokol mtsokol force-pushed the array-api-cross branch 2 times, most recently from c80f03d to f7e5f66 Compare November 14, 2023 13:10
@mtsokol mtsokol added this to the 2.0.0 release milestone Dec 4, 2023
@ngoldbaum
Copy link
Member

ngoldbaum commented Dec 5, 2023

This looks good to me. xref #13718 for a little context.

It also looks like we've already deprecated the 2D cross product behavior:

In [2]: np.cross([1, 2], [2, 1])
<ipython-input-2-eec728c54e9b>:1: DeprecationWarning: Arrays of 2-dimensional vectors are deprecated. Use arrays of 3-dimensional vectors instead. (deprecated in NumPy 2.0)
  np.cross([1, 2], [2, 1])
Out[2]: array(-3)

In it goes. Thanks @mtsokol!

@ngoldbaum ngoldbaum merged commit be4e25f into numpy:main Dec 5, 2023
@mtsokol mtsokol deleted the array-api-cross branch December 5, 2023 16:21
This was referenced Dec 7, 2023
Closed
Closed
@rgommers rgommers mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mtsokol mtsokol

Labels

30 - API Numpy 2.0 API Changes

Projects

None yet

Milestone

2.0.0 release

Development

Successfully merging this pull request may close these issues.

2 participants

@mtsokol @ngoldbaum