TST: check for best-effort parsing in foreign locales#6264
TST: check for best-effort parsing in foreign locales#6264charris merged 3 commits intonumpy:masterfrom
Conversation
numpy/core/tests/test_longdouble.py
Outdated
There was a problem hiding this comment.
Heh, I didn't expect that, I would have expected an error. I assume what is being checked is that , is not handled as the radix character?
There was a problem hiding this comment.
That's how fromstring normally "handles" invalid input. But if , is the decimal marker in your locale and you're in python 2.6 and you don't have strtold_l, as @pv points out, you don't get the 1 either.
TST: check for best-effort parsing in foreign locales
|
Thanks Anne. I notice you don't have commit rights, they got lost in the move to github. Do you want them back? |
|
The pull request workflow makes them a lot less necessary, and I think I need to get more used to the numpy coding style before I could approve any, but I'm willing to help when I have time. So if you think it would be useful, sure. |
|
I set you an invitation. If nothing else you are on the growing developers emeritus team;) |
No description provided.