DOC: Updated minor typos in function_base.py and test_function_base.py#7181
Merged
charris merged 1 commit intonumpy:masterfrom Feb 7, 2016
Merged
DOC: Updated minor typos in function_base.py and test_function_base.py#7181charris merged 1 commit intonumpy:masterfrom
charris merged 1 commit intonumpy:masterfrom
Conversation
Contributor
Author
|
I would like to make the request, if such a thing is possible, to have this PR backported the same way as as #7180, assuming they are both accepted and 7180 is backported. The reason is that most of this change is to the documentation of |
numpy/lib/nanfunctions.py
Outdated
Member
There was a problem hiding this comment.
Docstrings and comments should wrap at 72 columns, not 79, PEP 8 says so.
Contributor
Author
There was a problem hiding this comment.
Can't argue with PEP8. Fixed. Also, found a couple more typos and changed some wording around while fixing.
22eb43b to
baf9cf8
Compare
numpy/lib/function_base.py
Outdated
f506270 to
f2c5b6a
Compare
f2c5b6a to
917e530
Compare
charris
added a commit
that referenced
this pull request
Feb 7, 2016
DOC: Updated minor typos in function_base.py and test_function_base.py
This was referenced Feb 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main correction was to fix up outputs in
nanpercentileexamples and make the docs look more like those ofpercentile.