Skip to content

add modifications to handle gfortran on msvc#9429

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

add modifications to handle gfortran on msvc#9429
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 16, 2017

This is currently wip (it fully works but needs to handle non msvc+gfortran). Feedback would be greatly appreciated to understand whether this is the correct approach.

@rgommers
Copy link
Member

Not sure if you still want feedback given that you closed the PR, but: if it takes listing scipy submodules explicitly then that's a lot better than nothing, but it's then not a generic solution for "Fortran + Python on Windows". I haven't been following in enough detail, but how sure are you that this is necessary?

@pv
Copy link
Member

pv commented Jul 17, 2017 via email

@rgommers
Copy link
Member

Does numpy.distutils preserve the library order given by the setup.py scripts?

It doesn't, and making it do so will be useful in other contexts as well. E.g. I just tried to move ndimage forward for a debugging exercise to not have to wait on sparsetools compiling, but couldn't get that to work via setup.py listings.

@ghost
Copy link
Author

ghost commented Jul 17, 2017

Not sure if you still want feedback given that you closed the PR

I inadvertently deleted the branch and github closed the PR.

@rgommers The other issue that I am unsure how to address is how to gracefully handle DLL dependencies . Do you have any ideas on this?

@ghost
Copy link
Author

ghost commented Jul 17, 2017

new pr: #9431 (gh wouldn't let me reopen this)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments