BUG: MaskedArray _optinfo dictionary is not updated when calling __eq__/__ne__#9540
Merged
eric-wieser merged 1 commit intonumpy:masterfrom Aug 13, 2017
Merged
BUG: MaskedArray _optinfo dictionary is not updated when calling __eq__/__ne__#9540eric-wieser merged 1 commit intonumpy:masterfrom
eric-wieser merged 1 commit intonumpy:masterfrom
Conversation
eric-wieser
reviewed
Aug 11, 2017
numpy/ma/tests/test_core.py
Outdated
| assert_equal(a._optinfo["key"], array(a, copy=True)._optinfo["key"]) | ||
| assert_equal(a._optinfo["key"], np.zeros_like(a)._optinfo["key"]) | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Should only be one line between methods - I don't think we make an exception for tests?
Member
There was a problem hiding this comment.
We don't, although I expect violations slip by. Might as well get it right in the first place.
eric-wieser
approved these changes
Aug 11, 2017
Member
eric-wieser
left a comment
There was a problem hiding this comment.
One minor style nit, but fix looks fine, and tests are thorough
Contributor
Author
|
I removed the excessive empty lines |
Member
|
Thanks @schaefed! Try to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces PR #9279. In order to follow the contribution guidelines (I think) I had to open a new one...