Conversation
Fil
approved these changes
Apr 26, 2023
a6edc7d to
359cf32
Compare
Member
Author
|
I’m not sure I want to merge this. I feel like you can already override the styles if you want to. Maybe this gives better default results, but maybe it just causes churn? 🤔 The shadow DOM approach seems attractive but that seems more disruptive too. Hmm. |
Contributor
|
Can we then close these PRs (or move them to draft status)? |
f42db68 to
dbfadd9
Compare
dbfadd9 to
9ca08e0
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* remove default white background * var(--plot-background) (observablehq#1513) * dark mode for dev * dev dark mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1434. When upgrading Observable, we can either restore the white background with an external stylesheet, or by changing the download PNG functionality.
Also fixes #1463.