Replace Svelte example with runes (v5.0.0+) and rm deprecated onmousemove#2242
Merged
Fil merged 5 commits intoobservablehq:mainfrom Nov 24, 2024
Merged
Conversation
Contributor
|
Thanks! I think we also need to link to a different playground url. (I pasted your changes and saved them to https://svelte.dev/playground/e65b5c87ae7e44239cef41ec3df28f52?version=5.2.7) |
Contributor
Author
|
Np! I was wondering, maybe it needs 2 versions, since v5.0.0 with runes is kind of new? I don't know if a lot of people still use Svelte v4.x.x or prior. But I was kind of struggling getting it working with the new runes, that's why I opened this PR. I also thought about removing the Typescript stuff since it's actually optional in Svelte |
Contributor
|
We don't want to make this documentation about svelte versions. Being up-to-date is good if you're starting a new project. The typescript stuff is not overwhelming, and can be helpful, so I think we can keep it. |
Fil
approved these changes
Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.