Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (32.86%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
============================================
+ Coverage 32.78% 32.86% +0.07%
- Complexity 973 974 +1
============================================
Files 182 182
Lines 6872 6880 +8
Branches 764 764
============================================
+ Hits 2253 2261 +8
Misses 4512 4512
Partials 107 107 ☔ View full report in Codecov by Sentry. |
rhamzeh
approved these changes
Feb 13, 2025
This was referenced Feb 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use HTTP 1.1 by default
Description
Configures the default
HttpClientto use HTTP 1.1 by default.There are issues observed using HTTP 2 with FGA, as observed in #126 and failures related to receiving GOAWAY frames.
This change updates the default configuration to use HTTP 1.1.
It also includes a new constructor for
ApiClient, to enable easier configuration for a customHttpClient. If customers wish to use HTTP 2, with this change they can configure the SDK like the following:References
#126
Review Checklist
main