Skip to content

feat: support contextual_tuples in expand requests#164

Merged
evansims merged 1 commit intomainfrom
feat/support-contextual-tuples-in-expand-requests
Jan 23, 2025
Merged

feat: support contextual_tuples in expand requests#164
evansims merged 1 commit intomainfrom
feat/support-contextual-tuples-in-expand-requests

Conversation

@evansims
Copy link
Contributor

@evansims evansims commented Jan 23, 2025 •
edited
Loading

Description

This PR adds support for contextual_tuples in expand requests. (It follows up with support for auto-generated changes already included in a previous commit, #163.)

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims mentioned this pull request Jan 23, 2025
Merged
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.56%. Comparing base (626939b) to head (17730f0).

Files with missing lines Patch % Lines
openfga_sdk/client/models/expand_request.py 80.00% 3 Missing ⚠️
openfga_sdk/client/client.py 50.00% 1 Missing ⚠️
openfga_sdk/sync/client/client.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files         135      135           
  Lines       10839    10857   +18     
=======================================
+ Hits         7540     7553   +13     
- Misses       3299     3304    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims added the enhancement New feature or request label Jan 23, 2025
@evansims evansims marked this pull request as ready for review January 23, 2025 19:50
@evansims evansims requested a review from a team as a code owner January 23, 2025 19:50
@evansims evansims enabled auto-merge January 23, 2025 19:52
This was referenced Jan 23, 2025
Merged
Merged
jimmyjames
jimmyjames reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any opportunity to add some (useful/meaningful) tests for this change?

@evansims
Copy link
Contributor Author

evansims commented Jan 23, 2025 •
edited
Loading

Any opportunity to add some (useful/meaningful) tests for this change?

@jimmyjames I don't think there'd be much benefit in this specific case, but I do have a follow-up PR I'm preparing (after 0.9.1. release) that includes a significantly reworked/expanded test suite and some proper integration tests for all endpoints. If you're OK with deferring the test coverage for a few, I'll include that in the follow-up PR.

@evansims evansims added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit ffa58f5 Jan 23, 2025
17 checks passed
@evansims evansims deleted the feat/support-contextual-tuples-in-expand-requests branch January 23, 2025 21:40
@ewanharris ewanharris mentioned this pull request Jan 24, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evansims @codecov-commenter @jimmyjames