Conversation
Collaborator
|
Shouldn't we support also 17 ? In practice probably used a lot. |
Collaborator
Author
|
Yeah, we could keep testing on 17, just wanted to check on 24 as well |
xstefank
approved these changes
Mar 23, 2025
Collaborator
xstefank
left a comment
There was a problem hiding this comment.
Agreed that 17 should be kept, otherwise looks good.
csviri
approved these changes
Mar 24, 2025
Signed-off-by: Chris Laprun <claprun@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun claprun@redhat.com