fix: retry finalizer removal on http 422#2776
Merged
Conversation
this can happen if there are multiple finalizers present and multiple reconilers competent to remove their finalizer, since we remove the finalizer with JSON Patch Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Collaborator
Author
|
see: #2759 (comment) |
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Collaborator
Author
|
cc @tomdw , checking the logs in the integration test I was able to confirm that indeed this happens with 422. Thank you for reporting. |
xstefank
approved these changes
Apr 30, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java
Outdated
Show resolved
Hide resolved
metacosm
reviewed
Apr 30, 2025
...ore/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
metacosm
approved these changes
Apr 30, 2025
|
@csviri any timeline on when the next release will be available including this fix? |
Collaborator
Author
|
I plan to do a release (probably 5.1) in two weeks. ( Feel free to have a local build o n your side from the main branch, that is always stable ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this can happen if there are multiple finalizers present and multiple reconilers competent to remove their finalizer, since we remove the finalizer with JSON Patch
Signed-off-by: Attila Mészáros a_meszaros@apple.com