Increase code coverage of SSABasedGenericKubernetesResourceMatcher#2781
Merged
metacosm merged 2 commits intooperator-framework:mainfrom May 12, 2025
Conversation
csviri
approved these changes
May 8, 2025
Collaborator
|
@Donnerbart @metacosm could you pls resolve the conflicts, after would like to merge this. thx |
Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
33f1f4e to
1abaea2
Compare
metacosm
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: 91% methods, 86% lines covered
After: 100% methods, 99% lines covered
This should be the only missing line now:
I hope you don't mind the re-ordering of the methods, but I find code always very hard to read if the methods are not sorted by their invocation order. The only changes to the production class are:
getDiff(),sortMap()andsortListItems()static.keepOnlyManagedFields()package private (to make it directly testable).