Conversation
xstefank
requested changes
May 21, 2025
xstefank
approved these changes
May 22, 2025
metacosm
requested changes
May 23, 2025
| // using the utility instead of update control | ||
| var updated = | ||
| PrimaryUpdateAndCacheUtils.ssaPatchStatusAndCacheResource(resource, freshCopy, context); | ||
| return UpdateControl.noUpdate(); |
Collaborator
There was a problem hiding this comment.
Why do you return noUpdate here? Shouldn't it return patchStatus instead?
Collaborator
Author
There was a problem hiding this comment.
It should not, the utils doess the patching.
Collaborator
There was a problem hiding this comment.
So, to be clear, if a user wants to use the utils, they need to return noUpdate? Or, it's just that it won't matter if they return something else?
Either way, that should be documented.
Collaborator
Author
There was a problem hiding this comment.
using the utility instead of update control , yes that might not be enough, will, expand on that, also a separate PR for the core docs
| The trick is to cache the resource from the response of our update in an additional cache on top of the informer's cache. | ||
| If we read the resource, we first check if it is in the overlay cache and read it from there if present, otherwise read it from the cache of the informer. | ||
| If the informer receives an event with a fresh resource, we always remove the resource from the overlay | ||
| cache, since that is a more recent resource. But this **works only** if the update is done **with optimistic locking**. |
Collaborator
There was a problem hiding this comment.
What does "update" refer to here? This isn't clear.
Collaborator
Author
There was a problem hiding this comment.
improved wording ot it
metacosm
approved these changes
May 24, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Co-authored-by: Martin Stefanko <xstefank122@gmail.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.