Conversation
8162728 to
64ae8ac
Compare
metacosm
left a comment
There was a problem hiding this comment.
The commit message should be changed as this isn't an actual support of Java 25, just running CI on Java 25.
|
Also, at this point, I don't think that there's a Temurin Java 25 distribution available. |
It is not the same thing? So basically the SDK works with java 25 |
No, will wait for that before this is merged. |
Well, not quite. We're just checking that it works with Java 25, not the same thing as actually doing something to support it. For that matter, have you actually checked that the SDK builds on Java 25? |
What I mean is this what we do for any java >17. But changed the title of the PR |
|
For info, I've tried building with Java 25 and it appears the spotless plugin doesn't work on Java 25. |
|
fixed |
|
Cool! We should still wait for the Temurin releases. |
|
Ah, I thought that the Temurin releases were available now, according to https://adoptium.net/temurin/releases/. Maybe it takes some time to propagate images? |
There is a github issue somehwere where they are tracking the exact progress, just can't find it anymore, but last week there was still a lot to done there |
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
650a4ea to
caf4557
Compare
Signed-off-by: Attila Mészáros a_meszaros@apple.com