feat: allow DependentResourceNode creation override#2961
Merged
csviri merged 1 commit intooperator-framework:mainfrom Sep 24, 2025
Merged
feat: allow DependentResourceNode creation override#2961csviri merged 1 commit intooperator-framework:mainfrom
csviri merged 1 commit intooperator-framework:mainfrom
Conversation
Signed-off-by: xstefank <xstefank122@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR enables CDI bean injection in Condition subclasses by making DependentResourceNode creation configurable through the DependentResourceFactory. This allows frameworks like Quarkus to override node creation and inject dependencies into conditions.
- Made
DependentResourceNodeclass public for external extensibility - Replaced direct node construction with factory method delegation
- Added default
createNodeFrommethod toDependentResourceFactoryinterface
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DependentResourceNode.java | Changed class visibility from package-private to public |
| DefaultManagedWorkflow.java | Replaced direct node instantiation with factory method call |
| DependentResourceFactory.java | Added default createNodeFrom method for customizable node creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
csviri
approved these changes
Sep 24, 2025
Collaborator
|
I'm fine with this but @metacosm is more competent to review it, let's wait for him too |
metacosm
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to provide CDI beans in the
Conditionsubclasses as requested in quarkiverse/quarkus-operator-sdk#720.