Small health check improvements#3021
Merged
csviri merged 4 commits intooperator-framework:mainfrom Oct 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in a debug log message and implements the getStatus() method for TimerEventSource to properly report health status instead of defaulting to UNKNOWN.
Key Changes:
- Corrected "for for" typo in InformerWrapper debug log
- Implemented
getStatus()method in TimerEventSource to return HEALTHY/UNHEALTHY based on running state - Refactored InformerWrappingEventSourceHealthIndicator to use more concise stream operation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TimerEventSource.java | Adds getStatus() method implementation to report HEALTHY when running, UNHEALTHY when stopped |
| TimerEventSourceTest.java | Adds assertions to verify status is HEALTHY/UNHEALTHY in appropriate test scenarios |
| InformerWrapper.java | Fixes typo "for for" → "for" and adjusts spacing in debug log message |
| InformerWrappingEventSourceHealthIndicator.java | Simplifies stream logic using anyMatch instead of filter/findAny |
| PollingEventSourceTest.java | Removes unnecessary throws declaration from test method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
Hi @Donnerbart I think this is reasonable to change it this way. Thank you! |
Collaborator
|
I did not checked yet, but this might be also interesting: |
xstefank
approved these changes
Oct 27, 2025
Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
Signed-off-by: David Sondermann <david.sondermann@hivemq.com>
4247e2a to
4eec857
Compare
Collaborator
|
thank you @Donnerbart ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're digging into a reported operator health issue right now, and I noticed the
for fortypo in the debug log.I also noticed a
RetryAndRescheduleTimerEventSourcewith statusUNKNOWNin the event source health indicators, caused byTimerEventSourcenot implementing thegetStatus()method. If that was intentional (since we don't know if the actual timer tasks have been executed successfully), I can drop that commit again.